Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mise à jour librairie de gestion des timezones (tzdata) #4177

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Mise à jour librairie de gestion des timezones (tzdata) #4177

merged 10 commits into from
Sep 17, 2024

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Sep 11, 2024 •
edited
Loading

Dans cette PR:

Erreur traitée

J'ai vu en local plusieurs fois l'erreur suivante, que j'avais laissé de côté pour le moment :

[error] GenServer :tzdata_release_updater terminating
** (ArgumentError) errors were found at the given arguments:

  * 2nd argument: not a tuple

    :erlang.element(1, :error)
    (tzdata 1.1.1) lib/tzdata/util.ex:223: Tzdata.Util.to_int/1

Plus tard dans mon flux twitter est apparu:

Je fais donc l'upgrade correspondante, mais vu la fraîcheur de la release (il y a 8 heures), je propose de patienter un peu avant de merger, voir si il n'y a pas de "contre-release" 😄

Changelogs

(initially generated with elixir generate_deps_changelogs.exs)

@thbar thbar requested a review from a team as a code owner September 11, 2024 14:17
@thbar thbar added the dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité label Sep 11, 2024
@AntoineAugusti
Copy link
Member

J'ai tenté de comprendre le %z de tzdata mais difficilement comme abbréviation lau/tzdata#147

AntoineAugusti
AntoineAugusti approved these changes Sep 12, 2024
View reviewed changes
mix.lock Outdated Show resolved Hide resolved
@thbar thbar mentioned this pull request Sep 12, 2024
Closed
@thbar
Copy link
Contributor Author

thbar commented Sep 16, 2024

Je ne vois pas de nouvelle release en mode panique (https://github.com/lau/tzdata/tags), je mergerai demain matin.

Un point intéressant à suivre:

@thbar
Copy link
Contributor Author

thbar commented Sep 17, 2024

@etalab/transport-tech je déploie cette PR. Si vous voyez des trucs chelous (cf fragilité remontée ici lau/tzdata#149), faites signe !

@thbar thbar added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit 958de1d Sep 17, 2024
4 checks passed
@thbar thbar deleted the upgrade-tzdata branch September 17, 2024 07:33
@ptitfred
Copy link
Contributor

@etalab/transport-tech je déploie cette PR. Si vous voyez des trucs chelous (cf fragilité remontée ici lau/tzdata#149), faites signe !

Well j'observe une volée de warnings causés par Code.eval_string/1 dans le test rajouté dans test/build_test.exs. Extrait :

warning: found quoted keyword "ymlr" but the quotes are not required.

(Le mix.lock quote les clefs en effet.)

@ptitfred ptitfred mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineAugusti AntoineAugusti AntoineAugusti approved these changes

Assignees
No one assigned
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbar @AntoineAugusti @ptitfred